Skip to content

build(deps): bump mod-simple-datatables to v4.1.0#2020

Merged
markdumay merged 1 commit into
mainfrom
build/mod-simple-datatables-v4.1.0
Jul 14, 2026
Merged

build(deps): bump mod-simple-datatables to v4.1.0#2020
markdumay merged 1 commit into
mainfrom
build/mod-simple-datatables-v4.1.0

Conversation

@markdumay

Copy link
Copy Markdown
Collaborator

Activates the wrapped data table shipped in #2018.

#2018 taught Hinode to render a wrapped data table uniformly and mark it with data-table-wrap / data-table-wrap-breakpoint, but the vendored mod-simple-datatables did not yet know what those markers meant — so a wrapped data table simply rendered unwrapped. gethinode/mod-simple-datatables#277 released as v4.1.0 and consumes them, applying the wrapped layout below the main breakpoint through simple-datatables' tableRender hook. This bump is the final link.

One line in go.mod; _vendor/ is gitignored, so CI re-vendors from the released tag.

Verification

Everything to date was verified against a local working-tree copy of the module. This is the first run against the published v4.1.0 artifact, resolved normally through go.mod — no workspace or replacements override. All 11 acceptance checks pass in a real browser, with zero uncaught console exceptions:

  • The module actually loads (it declares integration = "optional", so it only loads on pages listing it in frontmatter — a gate that silently made an earlier test vacuous).
  • A wrapped data table initialises cleanly below the breakpoint and renders wrapped; the pager reports 2 pages for 4 records at perPage=2, i.e. it counts records rather than the rendered rows.
  • Resizing below the breakpoint no longer throws (this exercises the library's own internal resize handler, which the first draft of the hook crashed).
  • Sort, page and search all survive a breakpoint crossing; searching a word present only in the wrapped column still matches; the no-results message renders cleanly.
  • The plain path still stripes per record at both widths, and the two-column case wraps with colspan="1".
  • .d-md-table-cell and .table-border-bottom-wrap survive PurgeCSS in the served stylesheet — they are safelisted precisely because nothing else in the theme emits them.

🤖 Generated with Claude Code

Activates the wrapped data table: the module applies the wrapped layout below
the main breakpoint through simple-datatables' tableRender hook. Until this
bump Hinode emitted the data-table-wrap markers but the vendored module ignored
them, so a wrapped data table rendered unwrapped.
@netlify

netlify Bot commented Jul 14, 2026

Copy link
Copy Markdown

Deploy Preview for gethinode-demo ready!

Name Link
🔨 Latest commit 6e7939c
🔍 Latest deploy log https://app.netlify.com/projects/gethinode-demo/deploys/6a561a5a9fdbb70007ed95e2
😎 Deploy Preview https://deploy-preview-2020--gethinode-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@markdumay markdumay enabled auto-merge July 14, 2026 11:20
@markdumay markdumay merged commit d0e34aa into main Jul 14, 2026
16 checks passed
@markdumay markdumay deleted the build/mod-simple-datatables-v4.1.0 branch July 14, 2026 11:23
markdumay added a commit that referenced this pull request Jul 14, 2026
The wrap argument now combines with sortable, paginate and searchable. Hinode
renders a wrapped data table uniformly and marks it with data-table-wrap;
mod-simple-datatables v4.1.0 applies the wrapped layout below the main
breakpoint through simple-datatables' tableRender hook, so sorting, searching
and paging keep operating on an unmodified row model.

Plain wrapped tables are now rendered once rather than twice, which halves their
markup, parses the Markdown once, and stops Flexsearch indexing them twice.

The work shipped across v3.0.6 and this release; see #2018 and #2020. Recorded
as a feature so the changelog reflects the new capability.
@markdumay

Copy link
Copy Markdown
Collaborator Author

🎉 This PR is included in version 3.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant